From 0a20141f36e951da87dce0c0be6dd018d8865330 Mon Sep 17 00:00:00 2001 From: Jeffrey Walton Date: Mon, 3 Jun 2019 06:32:24 -0400 Subject: [PATCH] Clear warning for assignment operator in HuffmanNode --- zdeflate.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/zdeflate.cpp b/zdeflate.cpp index fcabe209..d9c05959 100644 --- a/zdeflate.cpp +++ b/zdeflate.cpp @@ -98,11 +98,17 @@ HuffmanEncoder::HuffmanEncoder(const unsigned int *codeBits, unsigned int nCodes struct HuffmanNode { - // Coverity finding on uninitialized 'symbol' member HuffmanNode() : symbol(0), parent(0) {} HuffmanNode(const HuffmanNode& rhs) : symbol(rhs.symbol), parent(rhs.parent) {} + HuffmanNode& operator=(const HuffmanNode& rhs) + { + // No this guard + symbol = rhs.symbol; + parent = rhs.parent; + return *this; + } size_t symbol; union {size_t parent; unsigned depth, freq;};