arne
/
cryptopp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update comments

pull/723/head
Jeffrey Walton 2018-10-14 00:30:23 -04:00
parent 49d852ee8c
commit 0d6c86bae6
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
strciphr.cpp
View File

@ -199,7 +199,7 @@ void CFB_CipherTemplate<BASE>::ProcessData(byte *outString, const byte *inString
// Using 'outString' for both input and output leads to incorrect results.
//
// Benchmarking on Cortex-A7 and Cortex-A9 indicates removing the block
// below does not have a material effect on performance.
// below costs about 9 cpb for CFB mode on ARM.
//
// Also see https://github.com/weidai11/cryptopp/issues/683.
//
@ -235,8 +235,7 @@ void CFB_CipherTemplate<BASE>::ProcessData(byte *outString, const byte *inString
// One workaround is a distinct and aligned temporary buffer. It [mostly] works
// as expected but requires an extra allocation (casts not shown):
//
// std::string temp(length);
// std::memcpy(&temp[0], inString, length);
// std::string temp(inString, length);
// policy.Iterate(outString, &temp[0], cipherDir, length / bytesPerIteration);
//
memcpy(outString, inString, length);