arne
/
cryptopp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update comments 

Reference the bug report in DL_SignerBase::SignAndRestart for future readers
pull/871/head
Jeffrey Walton 2019-07-29 10:36:29 -04:00
parent f68f00f560
commit 176cab0dc5
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pubkey.h
View File

@ -1604,8 +1604,8 @@ public:
if (rng.CanIncorporateEntropy()) if (rng.CanIncorporateEntropy())
rng.IncorporateEntropy(representative, representative.size()); rng.IncorporateEntropy(representative, representative.size());
Integer k, ks;
const Integer& q = params.GetSubgroupOrder(); const Integer& q = params.GetSubgroupOrder();
Integer k;
if (alg.IsDeterministic()) if (alg.IsDeterministic())
{ {
const Integer& x = key.GetPrivateExponent(); const Integer& x = key.GetPrivateExponent();
@ -1617,7 +1617,9 @@ public:
k.Randomize(rng, 1, params.GetSubgroupOrder()-1); k.Randomize(rng, 1, params.GetSubgroupOrder()-1);
} }
Integer ks = k + q; // Due to timing attack on nonce length by Jancar
// https://github.com/weidai11/cryptopp/issues/869
ks = k + q;
if (ks.BitCount() == q.BitCount()) { if (ks.BitCount() == q.BitCount()) {
ks += q; ks += q;
} }
@ -1635,7 +1637,7 @@ public:
alg.Sign(params, key.GetPrivateExponent(), ma.m_k, e, r, s); alg.Sign(params, key.GetPrivateExponent(), ma.m_k, e, r, s);
*/ */
size_t rLen = alg.RLen(params); const size_t rLen = alg.RLen(params);
r.Encode(signature, rLen); r.Encode(signature, rLen);
s.Encode(signature+rLen, alg.SLen(params)); s.Encode(signature+rLen, alg.SLen(params));