arne
/
cryptopp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove copy ctor from DERGeneralEncoder and BERGeneralDecoder 

GCC was giving too many warnings at -Wextra. We also could not comply with Rule of 3 because it resulted in compile failures in C++98 and C++03
pull/858/head
Jeffrey Walton 2019-07-01 13:29:46 -04:00
parent c3d4e79a09
commit 445ec61125
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
2 changed files with 2 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
asn.cpp
View File

@ -406,12 +406,6 @@ BERGeneralDecoder::BERGeneralDecoder(BufferedTransformation &inQueue, byte asnTa
Init(asnTag); Init(asnTag);
} }
BERGeneralDecoder::BERGeneralDecoder(BERGeneralDecoder &inQueue)
: m_inQueue(inQueue), m_length(0), m_finished(false)
{
Init(DefaultTag);
}
BERGeneralDecoder::BERGeneralDecoder(BERGeneralDecoder &inQueue, byte asnTag) BERGeneralDecoder::BERGeneralDecoder(BERGeneralDecoder &inQueue, byte asnTag)
: m_inQueue(inQueue), m_length(0), m_finished(false) : m_inQueue(inQueue), m_length(0), m_finished(false)
{ {
@ -523,11 +517,6 @@ DERGeneralEncoder::DERGeneralEncoder(BufferedTransformation &outQueue, byte asnT
{ {
} }
DERGeneralEncoder::DERGeneralEncoder(DERGeneralEncoder &outQueue)
: m_outQueue(outQueue), m_asnTag(DefaultTag), m_finished(false)
{
}
DERGeneralEncoder::DERGeneralEncoder(DERGeneralEncoder &outQueue, byte asnTag) DERGeneralEncoder::DERGeneralEncoder(DERGeneralEncoder &outQueue, byte asnTag)
: m_outQueue(outQueue), m_asnTag(asnTag), m_finished(false) : m_outQueue(outQueue), m_asnTag(asnTag), m_finished(false)
{ {

14
asn.h
View File

@ -255,7 +255,7 @@ private:
}; };
/// \brief BER General Decoder /// \brief BER General Decoder
class CRYPTOPP_DLL BERGeneralDecoder : public Store, NotCopyable class CRYPTOPP_DLL BERGeneralDecoder : public Store
{ {
public: public:
/// \brief Default ASN.1 tag /// \brief Default ASN.1 tag
@ -273,11 +273,6 @@ public:
/// \param asnTag ASN.1 tag /// \param asnTag ASN.1 tag
explicit BERGeneralDecoder(BufferedTransformation &inQueue, byte asnTag); explicit BERGeneralDecoder(BufferedTransformation &inQueue, byte asnTag);
/// \brief Construct an ASN.1 decoder
/// \param inQueue input byte queue
/// \details BERGeneralDecoder uses DefaultTag
explicit BERGeneralDecoder(BERGeneralDecoder &inQueue);
/// \brief Construct an ASN.1 decoder /// \brief Construct an ASN.1 decoder
/// \param inQueue input byte queue /// \param inQueue input byte queue
/// \param asnTag ASN.1 tag /// \param asnTag ASN.1 tag
@ -371,7 +366,7 @@ private:
}; };
/// \brief DER General Encoder /// \brief DER General Encoder
class CRYPTOPP_DLL DERGeneralEncoder : public ByteQueue, NotCopyable class CRYPTOPP_DLL DERGeneralEncoder : public ByteQueue
{ {
public: public:
/// \brief Default ASN.1 tag /// \brief Default ASN.1 tag
@ -389,11 +384,6 @@ public:
/// \param asnTag ASN.1 tag /// \param asnTag ASN.1 tag
explicit DERGeneralEncoder(BufferedTransformation &outQueue, byte asnTag); explicit DERGeneralEncoder(BufferedTransformation &outQueue, byte asnTag);
/// \brief Construct an ASN.1 encoder
/// \param outQueue output byte queue
/// \details DERGeneralEncoder uses DefaultTag
explicit DERGeneralEncoder(DERGeneralEncoder &outQueue);
/// \brief Construct an ASN.1 encoder /// \brief Construct an ASN.1 encoder
/// \param outQueue output byte queue /// \param outQueue output byte queue
/// \param asnTag ASN.1 tag /// \param asnTag ASN.1 tag