arne
/
cryptopp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Cleared Coverity finding CID 170385 (UNINIT_CTOR) (Issue 293)

pull/294/head
Jeffrey Walton 2016-09-20 20:51:13 -04:00
parent c298dfdbb0
commit 584f2f2ad1
1 changed files with 22 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
integer.cpp
View File

@ -204,32 +204,39 @@ static word AtomicInverseModPower2(word A)
class DWord class DWord
{ {
public: public:
// Converity finding on default ctor. We've isntrumented the code, #if defined(CRYPTOPP_NATIVE_DWORD_AVAILABLE)
// and cannot uncover a case where it affects a result. DWord() : m_whole() { }
#if (defined(__COVERITY__) || CRYPTOPP_DEBUG) && defined(CRYPTOPP_NATIVE_DWORD_AVAILABLE)
// Repeating pattern of 1010 for debug builds to break things...
DWord() : m_whole(0) {memset(&m_whole, 0xa, sizeof(m_whole));}
#elif (defined(__COVERITY__) || CRYPTOPP_DEBUG) && !defined(CRYPTOPP_NATIVE_DWORD_AVAILABLE)
// Repeating pattern of 1010 for debug builds to break things...
DWord() : m_halfs() {memset(&m_halfs, 0xaa, sizeof(m_halfs));}
#else #else
DWord() {} DWord() : m_halfs() { }
#endif #endif
#ifdef CRYPTOPP_NATIVE_DWORD_AVAILABLE #ifdef CRYPTOPP_NATIVE_DWORD_AVAILABLE
explicit DWord(word low) : m_whole(low) {} explicit DWord(word low) : m_whole(low) { }
#else #else
explicit DWord(word low) explicit DWord(word low) : m_halfs()
{ {
m_halfs.low = low; m_halfs.low = low;
m_halfs.high = 0;
} }
#endif #endif
DWord(word low, word high) #if defined(CRYPTOPP_NATIVE_DWORD_AVAILABLE)
DWord(word low, word high) : m_whole()
#else
DWord(word low, word high) : m_halfs()
#endif
{ {
#if defined(CRYPTOPP_NATIVE_DWORD_AVAILABLE)
# if defined(IS_LITTLE_ENDIAN)
const word t[2] = {low,high};
memcpy(&m_whole, &t, sizeof(m_whole));
# else
const word t[2] = {high,low};
memcpy(&m_whole, &t, sizeof(m_whole));
# endif
#else
m_halfs.low = low; m_halfs.low = low;
m_halfs.high = high; m_halfs.high = high;
#endif
} }
static DWord Multiply(word a, word b) static DWord Multiply(word a, word b)
@ -312,6 +319,8 @@ public:
#endif #endif
} }
// TODO: When NATIVE_DWORD is in effect, we access high and low, which are inactive
// union members, and that's UB. Also see http://stackoverflow.com/q/11373203.
word GetLowHalf() const {return m_halfs.low;} word GetLowHalf() const {return m_halfs.low;}
word GetHighHalf() const {return m_halfs.high;} word GetHighHalf() const {return m_halfs.high;}
word GetHighHalfAsBorrow() const {return 0-m_halfs.high;} word GetHighHalfAsBorrow() const {return 0-m_halfs.high;}