Update head notes

pull/566/head
Jeffrey Walton 2018-01-11 13:16:13 -05:00
parent 691e7af29a
commit a49ff560e7
1 changed files with 14 additions and 1 deletions

View File

@ -6,6 +6,19 @@
// is needed because additional CXXFLAGS are required to enable the
// appropriate instructions sets in some build configurations.
// TODO: we still need to implement Power8 SHA. Once we have Power8 SHA,
// we should be able to use CRYPTOPP_POWER8_AES_AVAILABLE and
// CRYPTOPP_POWER8_SHA_AVAILABLE instead of the broader
// CRYPTOPP_POWER8_AVAILABLE. The change will need to be coordinated
// with the defines in config.h.
// TODO: Bob Wilkinson reported we are misdetecting CRYPTOPP_POWER8_AVAILABLE.
// The problem is, the updated compiler supports them but the down-level
// assembler and linker do not. We will probably need to fix that through
// the makefile, similar to the way x86 AES and SHA is handled. Another
// twist is, we don't have access to a test machine and it must be fixed
// for two compilers (IBM XL C/C++ and GCC). Ugh...
#include "pch.h"
#include "config.h"
#include "stdcpp.h"
@ -125,7 +138,7 @@ bool CPU_ProbePower8()
{
#if defined(CRYPTOPP_NO_CPU_FEATURE_PROBES)
return false;
#elif (CRYPTOPP_POWER7_AVAILABLE)
#elif (CRYPTOPP_POWER8_AVAILABLE)
# if defined(CRYPTOPP_GNU_STYLE_INLINE_ASSEMBLY)
// longjmp and clobber warnings. Volatile is required.