Fixed compiler errors on Apple due to cross product of {C++03,C++11} x {libc++, libstdc++}. It included bringing in the correct <memory> in <stdcpp.h>, and then only including <stdcpp.h> when <memory> was needed.

cryptlib.cpp

@@ -6,6 +6,8 @@
 
 #include "cryptlib.h"
 #include "misc.h"
+#include "stdcpp.h"
+#include "smartptr.h"
 #include "filters.h"
 #include "algparam.h"
 #include "fips140.h"
@@ -15,8 +17,6 @@
 #include "osrng.h"
 #include "trap.h"
 
-#include <memory>
-
 #if GCC_DIAGNOSTIC_AWARE
 # pragma GCC diagnostic ignored "-Wunused-value"
 # pragma GCC diagnostic ignored "-Wunused-variable"

datatest.cpp

@@ -8,8 +8,8 @@
 #include "queue.h"
 #include "validate.h"
 #include "trap.h"
+
 #include <iostream>
-#include <memory>
 
 USING_NAMESPACE(CryptoPP)
 USING_NAMESPACE(std)

default.cpp

@@ -2,9 +2,10 @@
 
 #include "pch.h"
 #include "default.h"
+#include "stdcpp.h"
 #include "queue.h"
+
 #include <time.h>
-#include <memory>
 
 #if GCC_DIAGNOSTIC_AWARE
 # pragma GCC diagnostic ignored "-Wunused-value"

filters.cpp

@@ -8,11 +8,9 @@
 #include "mqueue.h"
 #include "fltrimpl.h"
 #include "argnames.h"
+#include "stdcpp.h"
 #include "trap.h"
 
-#include <memory>
-#include <functional>
-
 #if GCC_DIAGNOSTIC_AWARE
 # pragma GCC diagnostic ignored "-Wunused-value"
 # pragma GCC diagnostic ignored "-Wunused-variable"

misc.h

@@ -3,13 +3,9 @@
 
 #include "cryptlib.h"
 #include "smartptr.h"
+#include "stdcpp.h"
 #include "trap.h"
 
-#include <cstring>	// for memcpy and memmove
-#include <cstddef>  // for size_t when -stdlib=libc++
-#include <iosfwd>	// for std::streamsize
-#include <limits>	// for std::numeric_limits
-
 #ifdef _MSC_VER
 	#if _MSC_VER >= 1400
 		// VC2005 workaround: disable declarations that conflict with winnt.h

pubkey.h

@@ -37,10 +37,9 @@
 #include "eprecomp.h"
 #include "fips140.h"
 #include "argnames.h"
+#include "stdcpp.h"
 #include "trap.h"
 
-#include <memory>
-
 // VC60 workaround: this macro is defined in shlobj.h and conflicts with a template parameter used in this file
 #undef INTERFACE
 

stdcpp.h

@@ -11,17 +11,31 @@
 #include <limits.h>
 #include <stdlib.h>
 #include <string.h>
+
+// http://marshall.calepin.co/c-and-xcode-46.html. LLVM places unique_ptr in std:: when using
+//   using -stdlib=libc++ (and not std::tr1::) regardless of C++03/C++11. We detect can detect
+//   it with _LIBCPP_VERSION, but its not accurate because Apple's built-in Clang behaves
+//   differently than a LLVM downloaded and compiled CLang. So we fall back to Clang's
+//   __has_include (http://clang.llvm.org/docs/LanguageExtensions.html#id3).
+#if (__cplusplus >= 201103L) && !defined(__clang__)
 #    include <memory>
+#elif defined(__clang__)
+#   if (__has_include(<tr1/memory>))
+#      include <tr1/memory>
+#   endif
+#elif (__cplusplus < 201103L)
+#   include <tr1/memory>
+#else
+#   include <memory>
+#endif
+
+#include <map>
+#include <vector>
 #include <string>
 #include <exception>
 #include <typeinfo>
 #include <algorithm>
-#include <map>
+#include <functional>
-#include <vector>
-
-#if !defined(_NDEBUG) && !defined(NDEBUG)
-# include <cassert>
-#endif
 
 #ifdef CRYPTOPP_INCLUDE_VECTOR_CC
 // workaround needed on Sun Studio 12u1 Sun C++ 5.10 SunOS_i386 128229-02 2009/09/21
@@ -29,9 +43,16 @@
 #endif
 
 // for alloca
-#ifdef __sun
+// #ifdef __sun
+// #include <alloca.h>
+// #elif defined(__MINGW32__) || defined(__BORLANDC__)
+// #include <malloc.h>
+// #endif
+
+// Rijdael uses alloca. Just include it for everyone....
 #include <alloca.h>
-#elif defined(__MINGW32__) || defined(__BORLANDC__)
+
+#if defined(__MINGW32__) || defined(__BORLANDC__)
 # include <malloc.h>
 #endif
 

validat1.cpp

@@ -3,6 +3,7 @@
 #include "pch.h"
 
 #define CRYPTOPP_ENABLE_NAMESPACE_WEAK 1
+#include "stdcpp.h"
 #include "files.h"
 #include "misc.h"
 #include "hex.h"
@@ -39,7 +40,6 @@
 #include "trap.h"
 
 #include <time.h>
-#include <memory>
 #include <iostream>
 #include <iomanip>