Clear warning for assignment operator in HuffmanNode

pull/853/head
Jeffrey Walton 2019-06-03 06:32:24 -04:00
parent 54d48ac1f4
commit 0a20141f36
No known key found for this signature in database
GPG Key ID: B36AB348921B1838
1 changed files with 7 additions and 1 deletions

View File

@ -98,11 +98,17 @@ HuffmanEncoder::HuffmanEncoder(const unsigned int *codeBits, unsigned int nCodes
struct HuffmanNode struct HuffmanNode
{ {
// Coverity finding on uninitialized 'symbol' member
HuffmanNode() HuffmanNode()
: symbol(0), parent(0) {} : symbol(0), parent(0) {}
HuffmanNode(const HuffmanNode& rhs) HuffmanNode(const HuffmanNode& rhs)
: symbol(rhs.symbol), parent(rhs.parent) {} : symbol(rhs.symbol), parent(rhs.parent) {}
HuffmanNode& operator=(const HuffmanNode& rhs)
{
// No this guard
symbol = rhs.symbol;
parent = rhs.parent;
return *this;
}
size_t symbol; size_t symbol;
union {size_t parent; unsigned depth, freq;}; union {size_t parent; unsigned depth, freq;};